More pep8 goodness

awx/main/models/base.py

@@ -141,7 +141,7 @@ class BaseModel(models.Model):
                 except ValidationError, e:
                     errors[f.name] = e.messages
         if errors:
-             raise ValidationError(errors)
+            raise ValidationError(errors)
 
     def update_fields(self, **kwargs):
         save = kwargs.pop('save', True)

awx/main/models/credential.py

@@ -357,8 +357,7 @@ class Credential(PasswordFieldsModel, CommonModelNameNotUnique):
             qs = qs.exclude(pk=model_class_pk)
         if qs.exists():
             key = NON_FIELD_ERRORS
-            errors.setdefault(key, []).append( \
-                self.unique_error_message(model_class, unique_check))
+            errors.setdefault(key, []).append(self.unique_error_message(model_class, unique_check))
         if errors:
             raise ValidationError(errors)
 

awx/main/models/inventory.py

@@ -229,6 +229,7 @@ class Inventory(CommonModel):
         # deepest level within the tree.
         root_group_pks = set(self.root_groups.values_list('pk', flat=True))
         group_depths = {} # pk: max_depth
+
         def update_group_depths(group_pk, current_depth=0):
             max_depth = group_depths.get(group_pk, -1)
             if current_depth > max_depth:
@@ -541,6 +542,7 @@ class Group(CommonModelNameNotUnique):
         from awx.main.tasks import update_inventory_computed_fields, bulk_inventory_element_delete
         from awx.main.utils import ignore_inventory_computed_fields
         from awx.main.signals import disable_activity_stream
+
         def mark_actual():
             all_group_hosts = Group.hosts.through.objects.select_related("host", "group").filter(group__inventory=self.inventory)
             group_hosts = {'groups': {}, 'hosts': {}}
@@ -1036,7 +1038,7 @@ class InventorySourceOptions(BaseModel):
         if invalid_filters:
             raise ValidationError('Invalid filter expression%s: %s' %
                                   ('' if len(invalid_filters) == 1 else 's',
-                                  ', '.join(invalid_filters)))
+                                   ', '.join(invalid_filters)))
         return instance_filters
 
     def clean_group_by(self):
@@ -1055,7 +1057,7 @@ class InventorySourceOptions(BaseModel):
         if invalid_choices:
             raise ValidationError('Invalid group by choice%s: %s' %
                                   ('' if len(invalid_choices) == 1 else 's',
-                                  ', '.join(invalid_choices)))
+                                   ', '.join(invalid_choices)))
         return ','.join(choices)
 
 

awx/main/models/jobs.py

@@ -266,7 +266,7 @@ class JobTemplate(UnifiedJobTemplate, JobOptions):
                                       (survey_element['variable'], data[survey_element['variable']], survey_element['max']))
                     if type(data[survey_element['variable']]) not in (float, int):
                         errors.append("Value %s for %s expected to be a numeric type" % (data[survey_element['variable']],
-                                                                                  survey_element['variable']))
+                                                                                         survey_element['variable']))
             elif survey_element['type'] == 'multiselect':
                 if survey_element['variable'] in data:
                     if type(data[survey_element['variable']]) != list:
@@ -446,7 +446,7 @@ class Job(UnifiedJob, JobOptions):
             dependencies.append(self.project.create_project_update(launch_type='dependency'))
         if inventory_sources.count(): # and not has_setup_failures?  Probably handled as an error scenario in the task runner
             for source in inventory_sources:
-                if not source in inventory_sources_found and source.needs_update_on_launch:
+                if source not in inventory_sources_found and source.needs_update_on_launch:
                     dependencies.append(source.create_inventory_update(launch_type='dependency'))
         return dependencies
 
@@ -491,12 +491,11 @@ class JobHostSummary(CreatedModifiedModel):
         editable=False,
     )
     host = models.ForeignKey('Host',
-        related_name='job_host_summaries',
-        null=True,
-        default=None,
-        on_delete=models.SET_NULL,
-        editable=False,
-    )
+                             related_name='job_host_summaries',
+                             null=True,
+                             default=None,
+                             on_delete=models.SET_NULL,
+                             editable=False)
 
     host_name = models.CharField(
         max_length=1024,

awx/main/models/unified_jobs.py

@@ -569,7 +569,7 @@ class UnifiedJob(PolymorphicModel, PasswordFieldsModel, CommonModelNameNotUnique
         # out the time that elapsed, do so.
         if self.started and self.finished and not self.elapsed:
             td = self.finished - self.started
-            elapsed = (td.microseconds + (td.seconds + td.days * 24 * 3600) * 10**6) / (10**6 * 1.0)
+            elapsed = (td.microseconds + (td.seconds + td.days * 24 * 3600) * 10 ** 6) / (10 ** 6 * 1.0)
         else:
             elapsed = 0.0
         if self.elapsed != elapsed: