assorted ui_next search phase 1 pr feedback updates

- remove unnecessary displayAll prop from ChipGroup
- update notification api fn to be 2 with no boolean param
- fix params passing to api functions
This commit is contained in:
John Mitchell
2019-07-30 13:57:16 -04:00
parent f0ff5b190a
commit 30253d21fc
12 changed files with 117 additions and 73 deletions

View File

@@ -403,7 +403,11 @@ describe('qs (qs.js)', () => {
defaultParams: { page: 1, page_size: 15 },
integerFields: ['page', 'page_size'],
};
const oldParams = { baz: ['bar', 'bang', 'bust'], page: 3, page_size: 15 };
const oldParams = {
baz: ['bar', 'bang', 'bust'],
page: 3,
page_size: 15,
};
const newParams = { baz: 'bar' };
expect(removeParams(config, oldParams, newParams)).toEqual({
baz: ['bang', 'bust'],
@@ -433,7 +437,12 @@ describe('qs (qs.js)', () => {
defaultParams: { page: 1, page_size: 15 },
integerFields: ['page', 'page_size'],
};
const oldParams = { baz: ['bar', 'bang', 'bust'], pat: 'pal', page: 3, page_size: 15 };
const oldParams = {
baz: ['bar', 'bang', 'bust'],
pat: 'pal',
page: 3,
page_size: 15,
};
const newParams = { baz: 'bust', pat: 'pal' };
expect(removeParams(config, oldParams, newParams)).toEqual({
baz: ['bar', 'bang'],
@@ -491,7 +500,11 @@ describe('qs (qs.js)', () => {
defaultParams: { page: 1, page_size: 15 },
integerFields: ['page', 'page_size'],
};
const oldParams = { baz: ['bar', 'bang', 'bust'], page: 3, page_size: 15 };
const oldParams = {
baz: ['bar', 'bang', 'bust'],
page: 3,
page_size: 15,
};
const newParams = { baz: 'bar' };
expect(removeParams(config, oldParams, newParams)).toEqual({
baz: ['bang', 'bust'],
@@ -521,7 +534,12 @@ describe('qs (qs.js)', () => {
defaultParams: { page: 1, page_size: 15 },
integerFields: ['page', 'page_size'],
};
const oldParams = { baz: ['bar', 'bang', 'bust'], pat: 'pal', page: 3, page_size: 15 };
const oldParams = {
baz: ['bar', 'bang', 'bust'],
pat: 'pal',
page: 3,
page_size: 15,
};
const newParams = { baz: 'bust', pat: 'pal' };
expect(removeParams(config, oldParams, newParams)).toEqual({
baz: ['bar', 'bang'],