zware/awx
1
0
Fork 0
mirror of https://github.com/ZwareBear/awx.git synced 2026-04-25 09:21:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1016 from cchurch/fix-job-template-launch-fields

Browse Source 
Remove write-only fields from GET response for job template launch.
This commit is contained in:
Chris Church
2016-02-24 18:12:47 -05:00
parent 8dbe24cb4f 90d1a3d020
commit 5b89c5e126
2 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
awx/api/serializers.py
View File

@@ -1970,7 +1970,7 @@ class JobLaunchSerializer(BaseSerializer):
variables_needed_to_start = serializers.ReadOnlyField()
credential_needed_to_start = serializers.SerializerMethodField()
survey_enabled = serializers.SerializerMethodField()
extra_vars = VerbatimField(required=False)
extra_vars = VerbatimField(required=False, write_only=True)
class Meta:
model = JobTemplate
@@ -1978,18 +1978,11 @@ class JobLaunchSerializer(BaseSerializer):
'ask_variables_on_launch', 'survey_enabled', 'variables_needed_to_start',
'credential', 'credential_needed_to_start',)
read_only_fields = ('ask_variables_on_launch',)
write_only_fields = ('credential', 'extra_vars',)
def to_representation(self, obj):
res = super(JobLaunchSerializer, self).to_representation(obj)
view = self.context.get('view', None)
if obj and hasattr(view, '_raw_data_form_marker'):
if obj.passwords_needed_to_start:
password_keys = dict([(p, u'') for p in obj.passwords_needed_to_start])
res.update(password_keys)
if self.get_credential_needed_to_start(obj) is True:
res.update(dict(credential=''))
return res
extra_kwargs = {
'credential': {
'write_only': True,
},
}
def get_credential_needed_to_start(self, obj):
return not (obj and obj.credential and obj.credential.active)