From afe09695d42559de71a6ea13f7bc9000d7ba0fc0 Mon Sep 17 00:00:00 2001 From: Keith Grant Date: Thu, 1 Oct 2020 08:53:37 -0700 Subject: [PATCH] update tests --- awx/ui_next/src/components/StatusIcon/StatusIcon.jsx | 2 +- awx/ui_next/src/screens/Job/JobDetail/JobDetail.test.jsx | 8 ++++++-- .../src/screens/Job/JobOutput/HostEventModal.test.jsx | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/awx/ui_next/src/components/StatusIcon/StatusIcon.jsx b/awx/ui_next/src/components/StatusIcon/StatusIcon.jsx index 2565765f00..7d9973f92e 100644 --- a/awx/ui_next/src/components/StatusIcon/StatusIcon.jsx +++ b/awx/ui_next/src/components/StatusIcon/StatusIcon.jsx @@ -129,7 +129,7 @@ const StatusIcon = ({ status, ...props }) => { )} - {status} + {status} ); }; diff --git a/awx/ui_next/src/screens/Job/JobDetail/JobDetail.test.jsx b/awx/ui_next/src/screens/Job/JobDetail/JobDetail.test.jsx index 2d5ff5d5fe..729d043686 100644 --- a/awx/ui_next/src/screens/Job/JobDetail/JobDetail.test.jsx +++ b/awx/ui_next/src/screens/Job/JobDetail/JobDetail.test.jsx @@ -28,14 +28,18 @@ describe('', () => { expect(wrapper.find(`Detail[label="${label}"] dd`).text()).toBe(value); } - assertDetail('Status', 'Successful'); + // StatusIcon adds visibly hidden accessibility text " successful " + assertDetail('Status', ' successful Successful'); assertDetail('Started', '8/8/2019, 7:24:18 PM'); assertDetail('Finished', '8/8/2019, 7:24:50 PM'); assertDetail('Job Template', mockJobData.summary_fields.job_template.name); assertDetail('Job Type', 'Run'); assertDetail('Launched By', mockJobData.summary_fields.created_by.username); assertDetail('Inventory', mockJobData.summary_fields.inventory.name); - assertDetail('Project', mockJobData.summary_fields.project.name); + assertDetail( + 'Project', + ` successful ${mockJobData.summary_fields.project.name}` + ); assertDetail('Revision', mockJobData.scm_revision); assertDetail('Playbook', mockJobData.playbook); assertDetail('Verbosity', '0 (Normal)'); diff --git a/awx/ui_next/src/screens/Job/JobOutput/HostEventModal.test.jsx b/awx/ui_next/src/screens/Job/JobOutput/HostEventModal.test.jsx index 01b6ed61bd..bb4b538142 100644 --- a/awx/ui_next/src/screens/Job/JobOutput/HostEventModal.test.jsx +++ b/awx/ui_next/src/screens/Job/JobOutput/HostEventModal.test.jsx @@ -103,7 +103,8 @@ describe('HostEventModal', () => { expect(wrapper.find(`Detail[label="${label}"] dd`).text()).toBe(value); } - assertDetail('Host Name', 'foo'); + // StatusIcon adds visibly hidden accessibility text " changed " + assertDetail('Host Name', ' changed foo'); assertDetail('Play', 'all'); assertDetail('Task', 'command'); assertDetail('Module', 'command');