Feedback from PR

specifically the scope that is used for attaching event listeners
for the $emit/$braodcast/$on that is used for routing socket messages.
Also removing some commented out code
This commit is contained in:
Jared Tabor
2016-10-06 18:42:18 -07:00
parent 39f337d933
commit c6d5f751fb
16 changed files with 104 additions and 120 deletions

View File

@@ -22,7 +22,6 @@ describe('Service: SocketService', () => {
it('should send to ws-jobs-summary', function(){
event = {data : {group_name: "jobs"}};
event.data = JSON.stringify(event.data);
console.log(event);
SocketService.onMessage(event);
expect(rootScope.$emit).toHaveBeenCalledWith('ws-jobs-summary', event.data);
});