Rolled back the onExit solution previously implemented to handle the backspace navigation on the job launch modal. New solution listens for state changes within the directive and cleans itself up.

This commit is contained in:
Michael Abashian
2016-07-15 12:00:26 -04:00
committed by John Mitchell
parent d389233b88
commit dfa42544a6
9 changed files with 9 additions and 85 deletions
-20
View File
@@ -255,16 +255,6 @@ var tower = angular.module('Tower', [
}); });
}); });
}] }]
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}). }).
@@ -274,16 +264,6 @@ var tower = angular.module('Tower', [
controller: JobsListController, controller: JobsListController,
ncyBreadcrumb: { ncyBreadcrumb: {
label: "JOBS" label: "JOBS"
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}). }).
@@ -17,15 +17,5 @@ export default {
}, },
ncyBreadcrumb: { ncyBreadcrumb: {
skip: true // Never display this state in breadcrumb. skip: true // Never display this state in breadcrumb.
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}; };
@@ -30,15 +30,5 @@ export default {
}] }]
}, },
templateUrl: templateUrl('job-detail/job-detail'), templateUrl: templateUrl('job-detail/job-detail'),
controller: 'JobDetailController', controller: 'JobDetailController'
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
}
}; };
@@ -89,6 +89,12 @@ export default [ 'templateUrl', 'CreateDialog', 'Wait', 'CreateSelect2', 'ParseT
} }
}; };
scope.$on("$stateChangeStart", function() {
scope.$evalAsync(function( scope ) {
scope.clearDialog();
});
});
scope.init(); scope.init();
} }
@@ -16,14 +16,8 @@ export default {
label: "CREATE JOB TEMPLATE" label: "CREATE JOB TEMPLATE"
}, },
onExit: function(){ onExit: function(){
// close the job launch modal // close the survey maker modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X" // using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
if($("#survey-modal-dialog").hasClass('ui-dialog-content')) { if($("#survey-modal-dialog").hasClass('ui-dialog-content')) {
$('#survey-modal-dialog').dialog('destroy'); $('#survey-modal-dialog').dialog('destroy');
@@ -19,14 +19,8 @@ export default {
label: "{{name}}" label: "{{name}}"
}, },
onExit: function(){ onExit: function(){
// close the job launch modal // close the survey maker modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X" // using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
if($("#survey-modal-dialog").hasClass('ui-dialog-content')) { if($("#survey-modal-dialog").hasClass('ui-dialog-content')) {
$('#survey-modal-dialog').dialog('destroy'); $('#survey-modal-dialog').dialog('destroy');
@@ -17,15 +17,5 @@ export default {
}, },
ncyBreadcrumb: { ncyBreadcrumb: {
label: "JOB TEMPLATES" label: "JOB TEMPLATES"
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}; };
@@ -121,16 +121,6 @@ export default [
features: ['FeaturesService', function(FeaturesService) { features: ['FeaturesService', function(FeaturesService) {
return FeaturesService.get(); return FeaturesService.get();
}] }]
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}, },
{ {
@@ -24,15 +24,5 @@ export default {
templateUrl: templateUrl('portal-mode/portal-mode-jobs'), templateUrl: templateUrl('portal-mode/portal-mode-jobs'),
controller: PortalModeJobsController controller: PortalModeJobsController
} }
},
onExit: function(){
// close the job launch modal
// using an onExit event to handle cases where the user navs away using the url bar / back and not modal "X"
// Destroy the dialog
if($("#job-launch-modal").hasClass('ui-dialog-content')) {
$('#job-launch-modal').dialog('destroy');
}
// Remove the directive from the page (if it's there)
$('#content-container').find('submit-job').remove();
} }
}; };