From 605c5784c8f674319159daedf457f5f2412bf1ad Mon Sep 17 00:00:00 2001 From: John Mitchell Date: Thu, 22 Aug 2019 11:16:07 -0400 Subject: [PATCH 1/2] fix regression where clicking inside popover closed it --- awx/ui/client/src/shared/directives.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/awx/ui/client/src/shared/directives.js b/awx/ui/client/src/shared/directives.js index 6cbd603e4a..b97d3da533 100644 --- a/awx/ui/client/src/shared/directives.js +++ b/awx/ui/client/src/shared/directives.js @@ -873,7 +873,7 @@ function(SettingsUtils, i18n, $rootScope) { id_to_close = ""; if (element[0].id) { - template = ''; + template = ''; } scope.triggerPopover = function(e) { @@ -911,6 +911,7 @@ function(SettingsUtils, i18n, $rootScope) { function bindPopoverDismiss() { $('body').one('click.popover' + id_to_close, function(e) { + debugger; if ($(e.target).parents(id_to_close).length === 0) { // case: you clicked to open the popover and then you // clicked outside of it...hide it. From 36229d92ee083f8f50e53f66842f48e5f4f2f37d Mon Sep 17 00:00:00 2001 From: John Mitchell Date: Thu, 22 Aug 2019 12:55:54 -0400 Subject: [PATCH 2/2] remove inadverdent debugger --- awx/ui/client/src/shared/directives.js | 1 - 1 file changed, 1 deletion(-) diff --git a/awx/ui/client/src/shared/directives.js b/awx/ui/client/src/shared/directives.js index b97d3da533..32fc9a0f11 100644 --- a/awx/ui/client/src/shared/directives.js +++ b/awx/ui/client/src/shared/directives.js @@ -911,7 +911,6 @@ function(SettingsUtils, i18n, $rootScope) { function bindPopoverDismiss() { $('body').one('click.popover' + id_to_close, function(e) { - debugger; if ($(e.target).parents(id_to_close).length === 0) { // case: you clicked to open the popover and then you // clicked outside of it...hide it.