enforce a stable list order when attaching/detaching instance groups

awx/main/migrations/0073_v360_create_instance_group_m2m.py

@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.20 on 2019-05-06 13:48
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('main', '0072_v350_deprecate_fields'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='InventoryInstanceGroupMembership',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('position', models.PositiveIntegerField(default=None, null=True, db_index=True)),
+                ('instancegroup', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.InstanceGroup')),
+                ('inventory', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.Inventory')),
+            ],
+        ),
+        migrations.CreateModel(
+            name='OrganizationInstanceGroupMembership',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('position', models.PositiveIntegerField(default=None, null=True, db_index=True)),
+                ('instancegroup', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.InstanceGroup')),
+                ('organization', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.Organization')),
+            ],
+        ),
+        migrations.CreateModel(
+            name='UnifiedJobTemplateInstanceGroupMembership',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('position', models.PositiveIntegerField(default=None, null=True, db_index=True)),
+                ('instancegroup', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.InstanceGroup')),
+                ('unifiedjobtemplate', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='main.UnifiedJobTemplate')),
+            ],
+        ),
+    ]

awx/main/migrations/0074_v360_migrate_instance_group_relations.py

@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.20 on 2019-05-06 13:49
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+def create_through_relations(apps, schema_editor):
+    relations = [
+        [
+            'UnifiedJobTemplate',
+            apps.get_model('main', 'UnifiedJobTemplateInstanceGroupMembership'),
+        ],
+        [
+            'Organization',
+            apps.get_model('main', 'OrganizationInstanceGroupMembership'),
+        ],
+        [
+            'Inventory',
+            apps.get_model('main', 'InventoryInstanceGroupMembership'),
+        ],
+    ]
+    for cls, Membership in relations:
+        Target = apps.get_model('main', cls)
+        for x in Target.objects.iterator():
+            for i, instance_group in enumerate(x.instance_groups.all()):
+                Membership(
+                    instancegroup=instance_group,
+                    position=i,
+                    **{'%s' % cls.lower(): x}
+                ).save()
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('main', '0073_v360_create_instance_group_m2m'),
+    ]
+
+    operations = [
+        migrations.RunPython(create_through_relations)
+    ]

awx/main/migrations/0075_v360_remove_old_instance_group_relations.py

@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.20 on 2019-05-06 15:15
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('main', '0074_v360_migrate_instance_group_relations'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='inventory',
+            name='instance_groups',
+        ),
+        migrations.RemoveField(
+            model_name='organization',
+            name='instance_groups',
+        ),
+        migrations.RemoveField(
+            model_name='unifiedjobtemplate',
+            name='instance_groups',
+        ),
+    ]

awx/main/migrations/0076_v360_add_new_instance_group_relations.py

@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.20 on 2019-05-06 15:20
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+from awx.main.fields import OrderedManyToManyField
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('main', '0075_v360_remove_old_instance_group_relations'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='inventory',
+            name='instance_groups',
+            field=OrderedManyToManyField(blank=True, through='main.InventoryInstanceGroupMembership', to='main.InstanceGroup'),
+        ),
+        migrations.AddField(
+            model_name='organization',
+            name='instance_groups',
+            field=OrderedManyToManyField(blank=True, through='main.OrganizationInstanceGroupMembership', to='main.InstanceGroup'),
+        ),
+        migrations.AddField(
+            model_name='unifiedjobtemplate',
+            name='instance_groups',
+            field=OrderedManyToManyField(blank=True, through='main.UnifiedJobTemplateInstanceGroupMembership', to='main.InstanceGroup'),
+        ),
+    ]