Merge ui and ui_next in one dir

Merge ui and ui_next in one dir

See: https://github.com/ansible/awx/issues/10676

Update django .po files

Update django .po files

Run `awx-manage makemessages`.

.dockerignore

@@ -1,3 +1,2 @@
 awx/ui/node_modules
-awx/ui_next/node_modules
 Dockerfile

.gitignore

@@ -28,12 +28,12 @@ awx/ui/build_test
 awx/ui/client/languages
 awx/ui/templates/ui/index.html
 awx/ui/templates/ui/installing.html
-awx/ui_next/node_modules/
+awx/ui/node_modules/
-awx/ui_next/src/locales/*/messages.js
+awx/ui/src/locales/*/messages.js
-awx/ui_next/coverage/
+awx/ui/coverage/
-awx/ui_next/build
+awx/ui/build
-awx/ui_next/.env.local
+awx/ui/.env.local
-awx/ui_next/instrumented
+awx/ui/instrumented
 rsyslog.pid
 tools/prometheus/data
 tools/docker-compose/ansible/awx_dump.sql
@@ -63,14 +63,12 @@ __pycache__
 /Gruntfile.js
 /Brocfile.js
 /bower.json
-/package.json
 /testem.yml
 **/coverage
 /.istanbul.yml
 **/node_modules/**
 /tmp
 **/npm-debug.log*
-**/package-lock.json
 
 # UI build flag files
 awx/ui/.deps_built
@@ -154,7 +152,7 @@ use_dev_supervisor.txt
 .idea/*
 *.unison.tmp
 *.#
-/awx/ui_next/.ui-built
+/awx/ui/.ui-built
 /Dockerfile
 /_build/
 /_build_kube_dev/

CONTRIBUTING.md

@@ -6,21 +6,21 @@ Have questions about this document or anything not covered here? Come chat with
 
 ## Table of contents
 
-* [Things to know prior to submitting code](#things-to-know-prior-to-submitting-code)
+- [Things to know prior to submitting code](#things-to-know-prior-to-submitting-code)
-* [Setting up your development environment](#setting-up-your-development-environment)
+- [Setting up your development environment](#setting-up-your-development-environment)
-  * [Prerequisites](#prerequisites)
+  - [Prerequisites](#prerequisites)
-    * [Docker](#docker)
+    - [Docker](#docker)
-    * [Docker compose](#docker-compose)
+    - [Docker compose](#docker-compose)
-    * [Frontend Development](#frontend-development)
+    - [Frontend Development](#frontend-development)
-  * [Build and Run the Development Environment](#build-and-run-the-development-environment)
+  - [Build and Run the Development Environment](#build-and-run-the-development-environment)
-    * [Fork and clone the AWX repo](#fork-and-clone-the-awx-repo)
+    - [Fork and clone the AWX repo](#fork-and-clone-the-awx-repo)
-  * [Building API Documentation](#building-api-documentation)
+  - [Building API Documentation](#building-api-documentation)
-  * [Accessing the AWX web interface](#accessing-the-awx-web-interface)
+  - [Accessing the AWX web interface](#accessing-the-awx-web-interface)
-  * [Purging containers and images](#purging-containers-and-images)
+  - [Purging containers and images](#purging-containers-and-images)
-* [What should I work on?](#what-should-i-work-on)
+- [What should I work on?](#what-should-i-work-on)
-* [Submitting Pull Requests](#submitting-pull-requests)
+- [Submitting Pull Requests](#submitting-pull-requests)
-* [PR Checks run by Zuul](#pr-checks-run-by-zuul)
+- [PR Checks run by Zuul](#pr-checks-run-by-zuul)
-* [Reporting Issues](#reporting-issues)
+- [Reporting Issues](#reporting-issues)
 
 ## Things to know prior to submitting code
 
@@ -46,15 +46,15 @@ respectively.
 
 For Linux platforms, refer to the following from Docker:
 
-* **Fedora** - https://docs.docker.com/engine/installation/linux/docker-ce/fedora/
+- **Fedora** - https://docs.docker.com/engine/installation/linux/docker-ce/fedora/
 
-* **CentOS** - https://docs.docker.com/engine/installation/linux/docker-ce/centos/
+- **CentOS** - https://docs.docker.com/engine/installation/linux/docker-ce/centos/
 
-* **Ubuntu** - https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/
+- **Ubuntu** - https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/
 
-* **Debian** - https://docs.docker.com/engine/installation/linux/docker-ce/debian/
+- **Debian** - https://docs.docker.com/engine/installation/linux/docker-ce/debian/
 
-* **Arch** - https://wiki.archlinux.org/index.php/Docker
+- **Arch** - https://wiki.archlinux.org/index.php/Docker
 
 #### Docker Compose
 
@@ -66,7 +66,7 @@ If you're not using Docker for Mac, or Docker for Windows, you may need, or choo
 
 #### Frontend Development
 
-See [the ui development documentation](awx/ui_next/CONTRIBUTING.md).
+See [the ui development documentation](awx/ui/CONTRIBUTING.md).
 
 #### Fork and clone the AWX repo
 
@@ -74,19 +74,19 @@ If you have not done so already, you'll need to fork the AWX repo on GitHub. For
 
 ### Build and Run the Development Environment
 
-See the [README.md](./tools/docker-compose/README.md) for docs on how to build the awx_devel image and run the development environment.  
+See the [README.md](./tools/docker-compose/README.md) for docs on how to build the awx_devel image and run the development environment.
 
 ### Building API Documentation
 
 AWX includes support for building [Swagger/OpenAPI
-documentation](https://swagger.io).  To build the documentation locally, run:
+documentation](https://swagger.io). To build the documentation locally, run:
 
 ```bash
 (container)/awx_devel$ make swagger
 ```
 
 This will write a file named `swagger.json` that contains the API specification
-in OpenAPI format.  A variety of online tools are available for translating
+in OpenAPI format. A variety of online tools are available for translating
 this data into more consumable formats (such as HTML). http://editor.swagger.io
 is an example of one such service.
 
@@ -126,15 +126,15 @@ Fixes and Features for AWX will go through the Github pull request process. Subm
 
 Here are a few things you can do to help the visibility of your change, and increase the likelihood that it will be accepted:
 
-* No issues when running linters/code checkers
+- No issues when running linters/code checkers
-  * Python: black: `(container)/awx_devel$ make black`
+  - Python: black: `(container)/awx_devel$ make black`
-  * Javascript: JsHint: `(container)/awx_devel$ make jshint`
+  - Javascript: `(container)/awx_devel$ make ui-lint`
-* No issues from unit tests
+- No issues from unit tests
-  * Python: py.test: `(container)/awx_devel$ make test`
+  - Python: py.test: `(container)/awx_devel$ make test`
-  * JavaScript: Jasmine: `(container)/awx_devel$ make ui-test-ci`
+  - JavaScript: `(container)/awx_devel$ make ui-test`
-* Write tests for new functionality, update/add tests for bug fixes
+- Write tests for new functionality, update/add tests for bug fixes
-* Make the smallest change possible
+- Make the smallest change possible
-* Write good commit messages. See [How to write a Git commit message](https://chris.beams.io/posts/git-commit/).
+- Write good commit messages. See [How to write a Git commit message](https://chris.beams.io/posts/git-commit/).
 
 It's generally a good idea to discuss features with us first by engaging us in the `#ansible-awx` channel on irc.libera.chat, or on the [mailing list](https://groups.google.com/forum/#!forum/awx-project).
 
@@ -146,21 +146,24 @@ Sometimes it might take us a while to fully review your PR. We try to keep the `
 All submitted PRs will have the linter and unit tests run against them via Zuul, and the status reported in the PR.
 
 ## PR Checks run by Zuul
+
 Zuul jobs for awx are defined in the [zuul-jobs](https://github.com/ansible/zuul-jobs) repo.
 
 Zuul runs the following checks that must pass:
-1) `tox-awx-api-lint`
+
-2) `tox-awx-ui-lint`
+1. `tox-awx-api-lint`
-3) `tox-awx-api`
+2. `tox-awx-ui-lint`
-4) `tox-awx-ui`
+3. `tox-awx-api`
-5) `tox-awx-swagger`
+4. `tox-awx-ui`
+5. `tox-awx-swagger`
 
 Zuul runs the following checks that are non-voting (can not pass but serve to inform PR reviewers):
-1) `tox-awx-detect-schema-change`
+
-    This check generates the schema and diffs it against a reference copy of the `devel` version of the schema.
+1. `tox-awx-detect-schema-change`
-    Reviewers should inspect the `job-output.txt.gz` related to the check if their is a failure (grep for `diff -u -b` to find beginning of diff).
+   This check generates the schema and diffs it against a reference copy of the `devel` version of the schema.
-    If the schema change is expected and makes sense in relation to the changes made by the PR, then you are good to go!
+   Reviewers should inspect the `job-output.txt.gz` related to the check if their is a failure (grep for `diff -u -b` to find beginning of diff).
-    If not, the schema changes should be fixed, but this decision must be enforced by reviewers.
+   If the schema change is expected and makes sense in relation to the changes made by the PR, then you are good to go!
+   If not, the schema changes should be fixed, but this decision must be enforced by reviewers.
 
 ## Reporting Issues
 

MANIFEST.in

@@ -4,8 +4,8 @@ recursive-include awx *.mo
 recursive-include awx/static *
 recursive-include awx/templates *.html
 recursive-include awx/api/templates *.md *.html
-recursive-include awx/ui_next/build *.html
+recursive-include awx/ui/build *.html
-recursive-include awx/ui_next/build *
+recursive-include awx/ui/build *
 recursive-include awx/playbooks *.yml
 recursive-include awx/lib/site-packages *
 recursive-include awx/plugins *.ps1

Makefile

@@ -383,49 +383,49 @@ bulk_data:
 # UI TASKS
 # --------------------------------------
 
-UI_BUILD_FLAG_FILE = awx/ui_next/.ui-built
+UI_BUILD_FLAG_FILE = awx/ui/.ui-built
 
 clean-ui:
 	rm -rf node_modules
-	rm -rf awx/ui_next/node_modules
+	rm -rf awx/ui/node_modules
-	rm -rf awx/ui_next/build
+	rm -rf awx/ui/build
-	rm -rf awx/ui_next/src/locales/_build
+	rm -rf awx/ui/src/locales/_build
 	rm -rf $(UI_BUILD_FLAG_FILE)
 
-awx/ui_next/node_modules:
+awx/ui/node_modules:
-	NODE_OPTIONS=--max-old-space-size=4096 $(NPM_BIN) --prefix awx/ui_next --loglevel warn ci
+	NODE_OPTIONS=--max-old-space-size=4096 $(NPM_BIN) --prefix awx/ui --loglevel warn ci
 
 $(UI_BUILD_FLAG_FILE):
 	$(PYTHON) tools/scripts/compilemessages.py
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run compile-strings
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run compile-strings
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run build
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run build
 	mkdir -p awx/public/static/css
 	mkdir -p awx/public/static/js
 	mkdir -p awx/public/static/media
-	cp -r awx/ui_next/build/static/css/* awx/public/static/css
+	cp -r awx/ui/build/static/css/* awx/public/static/css
-	cp -r awx/ui_next/build/static/js/* awx/public/static/js
+	cp -r awx/ui/build/static/js/* awx/public/static/js
-	cp -r awx/ui_next/build/static/media/* awx/public/static/media
+	cp -r awx/ui/build/static/media/* awx/public/static/media
 	touch $@
 
-ui-release: awx/ui_next/node_modules $(UI_BUILD_FLAG_FILE)
+ui-release: awx/ui/node_modules $(UI_BUILD_FLAG_FILE)
 
-ui-devel: awx/ui_next/node_modules
+ui-devel: awx/ui/node_modules
 	@$(MAKE) -B $(UI_BUILD_FLAG_FILE)
 
-ui-devel-instrumented: awx/ui_next/node_modules
+ui-devel-instrumented: awx/ui/node_modules
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run start-instrumented
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run start-instrumented
 
-ui-devel-test: awx/ui_next/node_modules
+ui-devel-test: awx/ui/node_modules
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run start
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run start
 
 ui-lint:
-	$(NPM_BIN) --prefix awx/ui_next install
+	$(NPM_BIN) --prefix awx/ui install
-	$(NPM_BIN) run --prefix awx/ui_next lint
+	$(NPM_BIN) run --prefix awx/ui lint
-	$(NPM_BIN) run --prefix awx/ui_next prettier-check
+	$(NPM_BIN) run --prefix awx/ui prettier-check
 
 ui-test:
-	$(NPM_BIN) --prefix awx/ui_next install
+	$(NPM_BIN) --prefix awx/ui install
-	$(NPM_BIN) run --prefix awx/ui_next test -- --coverage --maxWorkers=4 --watchAll=false
+	$(NPM_BIN) run --prefix awx/ui test -- --coverage --maxWorkers=4 --watchAll=false
 
 
 # Build a pip-installable package into dist/ with a timestamped version number.
@@ -578,11 +578,11 @@ awx-kube-dev-build: Dockerfile.kube-dev
 
 # generate UI .pot file, an empty template of strings yet to be translated
 pot: $(UI_BUILD_FLAG_FILE)
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run extract-template --clean
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run extract-template --clean
 
 # generate UI .po files for each locale (will update translated strings for `en`)
 po: $(UI_BUILD_FLAG_FILE)
-	$(NPM_BIN) --prefix awx/ui_next --loglevel warn run extract-strings -- --clean
+	$(NPM_BIN) --prefix awx/ui --loglevel warn run extract-strings -- --clean
 
 # generate API django .pot .po
 LANG = "en-us"

awx/main/middleware.py

@@ -197,4 +197,4 @@ class MigrationRanCheckMiddleware(MiddlewareMixin):
         executor = MigrationExecutor(connection)
         plan = executor.migration_plan(executor.loader.graph.leaf_nodes())
         if bool(plan) and getattr(resolve(request.path), 'url_name', '') != 'migrations_notran':
-            return redirect(reverse("ui_next:migrations_notran"))
+            return redirect(reverse("ui:migrations_notran"))

awx/main/tests/functional/test_licenses.py

@@ -111,7 +111,7 @@ def test_python_and_js_licenses():
     api_licenses = index_licenses('%s/../docs/licenses' % base_dir)
     ui_licenses = index_licenses('%s/../docs/licenses/ui' % base_dir)
     api_requirements = read_api_requirements('%s/../requirements' % base_dir)
-    ui_requirements = read_ui_requirements('%s/ui_next' % base_dir)
+    ui_requirements = read_ui_requirements('%s/ui' % base_dir)
 
     errors = []
     errors += remediate_licenses_and_requirements(ui_licenses, ui_requirements)

awx/settings/defaults.py

@@ -100,7 +100,7 @@ USE_L10N = True
 
 USE_TZ = True
 
-STATICFILES_DIRS = (os.path.join(BASE_DIR, 'ui_next', 'build', 'static'), os.path.join(BASE_DIR, 'static'))
+STATICFILES_DIRS = (os.path.join(BASE_DIR, 'ui', 'build', 'static'), os.path.join(BASE_DIR, 'static'))
 
 # Absolute filesystem path to the directory where static file are collected via
 # the collectstatic command.
@@ -288,7 +288,7 @@ TEMPLATES = [
             ],
             'builtins': ['awx.main.templatetags.swagger'],
         },
-        'DIRS': [os.path.join(BASE_DIR, 'templates'), os.path.join(BASE_DIR, 'ui_next', 'build'), os.path.join(BASE_DIR, 'ui_next', 'public')],
+        'DIRS': [os.path.join(BASE_DIR, 'templates'), os.path.join(BASE_DIR, 'ui', 'build'), os.path.join(BASE_DIR, 'ui', 'public')],
     }
 ]
 
@@ -316,7 +316,6 @@ INSTALLED_APPS = [
     'awx.main',
     'awx.api',
     'awx.ui',
-    'awx.ui_next',
     'awx.sso',
     'solo',
 ]

awx/sso/views.py

@@ -25,7 +25,7 @@ class BaseRedirectView(RedirectView):
     def get_redirect_url(self, *args, **kwargs):
         last_path = self.request.COOKIES.get('lastPath', '')
         last_path = urllib.parse.quote(urllib.parse.unquote(last_path).strip('"'))
-        url = reverse('ui_next:index')
+        url = reverse('ui:index')
         if last_path:
             return '%s#%s' % (url, last_path)
         else:

awx/ui/CONTRIBUTING.md

@@ -262,10 +262,10 @@ About.defaultProps = {
 
 There are currently a few custom hooks:
 
-1. [useRequest](https://github.com/ansible/awx/blob/devel/awx/ui_next/src/util/useRequest.js#L21) encapsulates main actions related to requests.
+1. [useRequest](https://github.com/ansible/awx/blob/devel/awx/ui/src/util/useRequest.js#L21) encapsulates main actions related to requests.
-2. [useDismissableError](https://github.com/ansible/awx/blob/devel/awx/ui_next/src/util/useRequest.js#L71) provides controls for "dismissing" an error message.
+2. [useDismissableError](https://github.com/ansible/awx/blob/devel/awx/ui/src/util/useRequest.js#L71) provides controls for "dismissing" an error message.
-3. [useDeleteItems](https://github.com/ansible/awx/blob/devel/awx/ui_next/src/util/useRequest.js#L98) handles deletion of items from a paginated item list.
+3. [useDeleteItems](https://github.com/ansible/awx/blob/devel/awx/ui/src/util/useRequest.js#L98) handles deletion of items from a paginated item list.
-4. [useSelected](https://github.com/ansible/awx/blob/devel/awx/ui_next/src/util/useSelected.js#L14) provides a way to read and update a selected list.
+4. [useSelected](https://github.com/ansible/awx/blob/devel/awx/ui/src/util/useSelected.js#L14) provides a way to read and update a selected list.
 
 ### Naming Functions
 

awx/ui/Dockerfile

@@ -4,7 +4,7 @@ ENV NPMRC_FILE=${NPMRC_FILE}
 ARG TARGET='https://awx:8043'
 ENV TARGET=${TARGET}
 ENV CI=true
-WORKDIR /ui_next
+WORKDIR /ui
 ADD public public
 ADD package.json package.json
 ADD package-lock.json package-lock.json

awx/ui/README.md

@@ -8,11 +8,11 @@ The API development server will need to be running. See [CONTRIBUTING.md](../../
 
 ```shell
 # install
-npm --prefix=awx/ui_next install
+npm --prefix=awx/ui install
 
 # Start the ui development server. While running, the ui will be reachable
 # at https://127.0.0.1:3001 and updated automatically when code changes.
-npm --prefix=awx/ui_next start
+npm --prefix=awx/ui start
 ```
 
 ### Build for the Development Containers
@@ -34,28 +34,28 @@ you'll need use the `TARGET` environment variable when starting the ui developme
 server:
 
 ```shell
-TARGET='https://awx.local:8043' npm --prefix awx/ui_next start
+TARGET='https://awx.local:8043' npm --prefix awx/ui start
 ```
 
 ## Testing
 ```shell
 # run code formatting check
-npm --prefix awx/ui_next run prettier-check
+npm --prefix awx/ui run prettier-check
 
 # run lint checks
-npm --prefix awx/ui_next run lint
+npm --prefix awx/ui run lint
 
 # run all unit tests
-npm --prefix awx/ui_next run test
+npm --prefix awx/ui run test
 
 # run a single test (in this case the login page test):
-npm --prefix awx/ui_next test -- src/screens/Login/Login.test.jsx
+npm --prefix awx/ui test -- src/screens/Login/Login.test.jsx
 
 # start the test watcher and run tests on files that you've changed
-npm --prefix awx/ui_next run test-watch
+npm --prefix awx/ui run test-watch
 
 # start the tests and get the coverage report after the tests have completed
-npm --prefix awx/ui_next run test -- --coverage
+npm --prefix awx/ui run test -- --coverage
 ```
 #### Note:
 - Once the test watcher is up and running you can hit `a` to run all the tests.
@@ -72,25 +72,25 @@ container to ensure consistency.
 docker exec -it tools_awx_1 bash
 
 # start with a fresh install of the current dependencies
-(tools_awx_1)$ make clean-ui && npm --prefix=awx/ui_next ci
+(tools_awx_1)$ make clean-ui && npm --prefix=awx/ui ci
 
 # add an exact development dependency
-(tools_awx_1)$ npm --prefix awx/ui_next install --save-dev --save-exact dev-package@1.2.3
+(tools_awx_1)$ npm --prefix awx/ui install --save-dev --save-exact dev-package@1.2.3
 
 # add an exact production dependency
-(tools_awx_1)$ npm --prefix awx/ui_next install --save --save-exact prod-package@1.23
+(tools_awx_1)$ npm --prefix awx/ui install --save --save-exact prod-package@1.23
 
 # remove a development dependency
-(tools_awx_1)$ npm --prefix awx/ui_next uninstall --save-dev dev-package
+(tools_awx_1)$ npm --prefix awx/ui uninstall --save-dev dev-package
 
 # remove a production dependency
-(tools_awx_1)$ npm --prefix awx/ui_next uninstall --save prod-package
+(tools_awx_1)$ npm --prefix awx/ui uninstall --save prod-package
 
 # exit the container
 (tools_awx_1)$ exit
 
 # add the updated package.json and package-lock.json files to scm
-git add awx/ui_next_next/package.json awx/ui_next_next/package-lock.json
+git add awx/ui/package.json awx/ui/package-lock.json
 ```
 #### Note:
 - Building the ui can use up a lot of resources. If you're running docker for mac or similar
@@ -98,8 +98,8 @@ virtualization, the default memory limit may not be enough and you should increa
 
 ## Building for Production
 ```shell
-# built files are placed in awx/ui_next/build
+# built files are placed in awx/ui/build
-npm --prefix awx/ui_next run build
+npm --prefix awx/ui run build
 ```
 
 ## CI Container
@@ -107,9 +107,9 @@ npm --prefix awx/ui_next run build
 To run:
 
 ```shell
-cd awx/awx/ui_next
+cd awx/awx/ui
 docker build -t awx-ui-next .
-docker run --name tools_ui_next_1 --network tools_default --link 'tools_awx_1:awx' -e TARGET="https://awx:8043" -p '3001:3001' --rm -v $(pwd)/src:/ui_next/src awx-ui-next
+docker run --name tools_ui_1 --network tools_default --link 'tools_awx_1:awx' -e TARGET="https://awx:8043" -p '3001:3001' --rm -v $(pwd)/src:/ui/src awx-ui-next
 ```
 
-**Note:** This is for CI, test systems, zuul, etc. For local development, see [usage](https://github.com/ansible/awx/blob/devel/awx/ui_next/README.md#Development)
+**Note:** This is for CI, test systems, zuul, etc. For local development, see [usage](https://github.com/ansible/awx/blob/devel/awx/ui/README.md#Development)

awx/ui/package-lock.json

@@ -1,6 +1,5 @@
 {
-  "name": "ui_next",
+  "name": "ui",
-  "version": "0.1.0",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {

awx/ui/package.json

@@ -1,6 +1,5 @@
 {
-  "name": "ui_next",
+  "name": "ui",
-  "version": "0.1.0",
   "private": true,
   "engines": {
     "node": "14.x"