Merge pull request #3686 from vismay-golwala/instance_group_delete

[WIP] Disallow deleting controller or isolated instance groups

Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]

awx/main/tests/functional/api/test_instance_group.py

@@ -78,6 +78,26 @@ def instance_group_jobs_successful(instance_group, create_job_factory, create_pr
     return jobs_successful + project_updates_successful
 
 
+@pytest.mark.django_db
+def test_instance_group_is_controller(instance_group, isolated_instance_group, non_iso_instance):
+    assert not isolated_instance_group.is_controller
+    assert instance_group.is_controller
+
+    instance_group.instances.set([non_iso_instance])
+
+    assert instance_group.is_controller
+
+
+@pytest.mark.django_db
+def test_instance_group_is_isolated(instance_group, isolated_instance_group):
+    assert not instance_group.is_isolated
+    assert isolated_instance_group.is_isolated
+
+    isolated_instance_group.instances = []
+
+    assert isolated_instance_group.is_isolated
+
+
 @pytest.mark.django_db
 def test_delete_instance_group_jobs(delete, instance_group_jobs_successful, instance_group, admin):
     url = reverse("api:instance_group_detail", kwargs={'pk': instance_group.pk})