Commit Graph

988 Commits

Author SHA1 Message Date
Matthew Jones
4eb6adb5e7 Add notification_template to summary fields 2016-06-27 15:35:34 -04:00
Akita Noek
831c4c2fef Cleaned up some more stale TODO's and FIXME's (or did / fixed the things) 2016-06-27 15:12:37 -04:00
Akita Noek
4bf50b2d6a Dead code removal 2016-06-27 15:12:37 -04:00
Akita Noek
bf6767786e Stale comment cleanup 2016-06-27 15:12:37 -04:00
Akita Noek
b57739a800 Converted except T,e expressions to except T as e 2016-06-27 15:12:37 -04:00
Akita Noek
7839db0c23 Dead code removal 2016-06-27 15:12:37 -04:00
Akita Noek
bf2307946b Locked down roles teams list 2016-06-27 15:12:37 -04:00
Akita Noek
d3476ed52a Filter out roles users shouldn't be able to see from parents/children lists 2016-06-27 15:12:37 -04:00
Matthew Jones
78e10241da Disallow DELETE on a notification_template
When there are pending notifications
2016-06-27 11:36:29 -04:00
Wayne Witzel III
f0418d8841 Merge pull request #2634 from wwitzel3/issue-2560
Disallow non-admin of a user to add a user to Roles
2016-06-27 11:28:38 -04:00
Wayne Witzel III
ce3ce8d930 enforce read access for team/child roles 2016-06-27 11:02:07 -04:00
Akita Noek
db02b446e5 Merge pull request #2646 from anoek/2628
Better handle missing notification_type in patches to notification template
2016-06-27 10:47:04 -04:00
Alan Rominger
9923728797 Merge pull request #2635 from AlanCoding/AS_test_pagination
Activity Stream update prefetched fields, avoid a .distinct().count()
2016-06-27 10:29:10 -04:00
Akita Noek
2b323fc24e Better handle notification template patches for notification_type
This makes it so patches don't require the notification_type to be present
2016-06-27 09:40:39 -04:00
Wayne Witzel III
87ffded774 renaming Credential.owner_role -> Credential.admin_role 2016-06-24 16:55:07 -04:00
Akita Noek
9494db583d Better handle missing notification_type in patches to notification template
Addresses #2628
2016-06-24 16:50:27 -04:00
AlanCoding
02dac5299c Activity Stream prefetch update to new fields, avoid distinct.count repeated queries 2016-06-24 14:19:41 -04:00
Akita Noek
ca2b4766a5 Removed some missed things from our Group role removal work
* Removed `groups/n/object_roles`
* Removed `groups/n/access_list`
* `active_roles` from the Group `summary_fields`

 #2631
2016-06-24 14:17:20 -04:00
Matthew Jones
a9162278f8 Perform length validation on notification lists
Wherever we use a list for notification template configuration we'll now
validate that it contains at least one item at submission time.
2016-06-23 11:31:59 -04:00
Wayne Witzel III
62293341bf Merge pull request #2592 from wwitzel3/issue-2349
filter out duplicate entires for the ActivityStream m2m relations
2016-06-23 11:01:42 -04:00
AlanCoding
d8f11459c9 flake8 fix membership in seralizer 2016-06-23 09:02:44 -04:00
Wayne Witzel III
68d47cfc93 Merge pull request #2574 from wwitzel3/fix-race
Ensure teams cannot have org roles as children.
2016-06-22 17:31:27 -04:00
Wayne Witzel III
5277d30d14 filter out duplicate entires for the ActivityStream m2m relations 2016-06-22 17:25:27 -04:00
Matthew Jones
960b6e22aa Fix up broken CredentialOwnerTeams view
Missing the object when requesting whether the user can access it or not
2016-06-22 15:17:45 -04:00
Matthew Jones
87f1f6f8e6 Update inventory script visibility access level
admin roles on inv scripts can now see the actual script contents.  Read
role doesn't convey that capability.

This should be pretty similar to before from a read_role
perspective... it now allows more folks to see the script contents
2016-06-22 13:48:38 -04:00
Wayne Witzel III
67e516f263 update language in error message 2016-06-22 12:14:11 -04:00
Wayne Witzel III
e07a06e990 Teams cannot be parents of Organization roles 2016-06-22 11:59:40 -04:00
AlanCoding
8fd18b882a move logic for project udpate to access.py 2016-06-20 12:05:41 -04:00
Chris Church
59361f5151 Fixes suggested by @AlanCoding. 2016-06-17 09:56:27 -04:00
Chris Church
cf7102bc49 Move validation of credential creation to the serializer. Use SubListCreateAPIView for creating a credential under another object, and remove fields from serializer and API docs that aren't valid when creating a credential under another object. 2016-06-17 09:56:27 -04:00
Wayne Witzel III
6f36497b6a updating URL to be _ instead of / 2016-06-16 17:05:42 -04:00
Alan Rominger
d9f62c4fa9 Merge pull request #2458 from AlanCoding/2453_proj_team_sub
/teams/N/projects/ queryset changed to reverse of /projects/N/teams/
2016-06-16 16:06:18 -04:00
AlanCoding
068a788958 team_project sublist to use same pattern as project_team 2016-06-16 13:18:47 -04:00
Alan Rominger
cfc763af07 Merge pull request #2444 from AlanCoding/2364_access_list_restriction
Filter access_list to users visible by requesting user
2016-06-16 13:07:30 -04:00
AlanCoding
54fa11cf25 restrict queryset for access_list to visable users 2016-06-16 11:05:57 -04:00
AlanCoding
5af6d14f27 protect launch endpoint against certain falsy values 2016-06-16 09:41:07 -04:00
Chris Church
45264c2009 Hide write-only fields from results in API docs. 2016-06-15 17:27:41 -04:00
Wayne Witzel III
6013a853f5 Merge pull request #2387 from wwitzel3/issue-2316
remove User.object_roles endpoint and discovery
2016-06-14 13:43:58 -04:00
Wayne Witzel III
203ebd20e8 remove the User.object_roles view 2016-06-14 11:42:23 -04:00
Wayne Witzel III
a47f47b790 remove URL and related mapping for User.object_roles 2016-06-14 11:42:08 -04:00
Alan Rominger
0583a7c435 Merge pull request #2353 from AlanCoding/2226_user_roles_access
Fixes for role assignment permissions
2016-06-14 11:25:33 -04:00
Wayne Witzel III
db7cfb23f8 added False return for permission check 2016-06-14 09:53:07 -04:00
AlanCoding
9d86fb0a09 change wording to reflect team sublist endpoint 2016-06-13 14:11:02 -04:00
Wayne Witzel III
568de86423 anyone with read_role should be able to view the can_update flag for a project 2016-06-13 12:07:39 -04:00
AlanCoding
b485b85076 TeamRolesList permission tests and fix, organize tests 2016-06-13 11:09:48 -04:00
AlanCoding
7f38227e11 fix bug in RoleTeamsList 2016-06-11 18:04:05 -04:00
Matthew Jones
753b338205 Make sure project team list is filtered for access 2016-06-10 15:10:37 -04:00
Matthew Jones
b612f65479 Fix up the project teams list
This was still referencing the old mechanism for pulling associative
information.  This updates it to query against the new role system
2016-06-10 15:06:14 -04:00
Wayne Witzel III
0f59314116 Merge pull request #2329 from wwitzel3/issue-2269
Add Organization FK to Credential
2016-06-10 11:32:24 -07:00
Wayne Witzel III
e243c8319d fix tests with refreshes 2016-06-10 13:41:22 -04:00