Commit Graph

2235 Commits

Author SHA1 Message Date
Bill Nottingham 5c16f8c294 Merge pull request #2451 from wenottingham/six-PRs-and-a-movie
Merge assorted PRs from the AWX community
2018-07-09 13:27:17 -04:00
Wayne Witzel III 8969276710 Merge pull request #2446 from ansible/issue-2330
Add explicit Job Template Admin role
2018-07-09 13:26:39 -04:00
Bill Nottingham ae4135f149 add tests 2018-07-09 12:59:45 -04:00
Paul Neumann 73197f3ae5 Extend unit test for Azure source variable generation
Add tests for generation of Azure source variables. Test cases such
as overwriting a variable with its default value, overwriting a variable
with something different to its default value and add variables not set
by default.
2018-07-09 12:59:14 -04:00
Wayne Witzel III 70a97ce998 Update test to reflect needing job_template_admin_role 2018-07-09 12:17:34 -04:00
Ryan Petrello 6bd9792518 default HTTP-based log emits to HTTPS
see: https://github.com/ansible/awx/issues/2048
2018-07-09 11:52:04 -04:00
chris meyers 19e865e9a5 prevent remove iso instance from iso instance groups 2018-07-06 15:34:26 -04:00
chris meyers aeca21ab5b deny topology changes to iso instances via api 2018-07-06 14:50:17 -04:00
Ryan Petrello 172defa0d4 don't use codecs.open for syncing isolated stdout data
see: https://github.com/ansible/tower/issues/2315
2018-07-06 08:25:51 -04:00
Alan Rominger 0b811a53ff Merge pull request #2410 from AlanCoding/filterama
Show filterable: False if not filterable
2018-07-03 17:32:11 -04:00
Alan Rominger 13c1b87df4 Merge pull request #2191 from AlanCoding/schedule_fixes
Fix bugs creating WFJT schedule with passwords
2018-07-03 16:51:01 -04:00
Alan Rominger 360ad7ad61 Merge branch 'release_3.3.0' into filterama 2018-07-03 15:42:37 -04:00
AlanCoding b97626bf37 show filterable: False if not filterable 2018-07-03 15:21:10 -04:00
Yunfan Zhang e9a2100a62 Merge pull request #2400 from YunfanZhang42/fix_content_type
Handle exception with invalid HTTP content_type.
2018-07-03 15:16:13 -04:00
Yunfan Zhang b4890ee331 Handle exception with invalid HTTP content_type.
Signed-off-by: Yunfan Zhang <yz322@duke.edu>
2018-07-03 13:55:18 -04:00
Ryan Petrello 4d7a20a9fb support env vars that contain unicode (without hanging)
see: https://github.com/ansible/tower/issues/2391
see: https://github.com/pexpect/pexpect/issues/512
2018-07-03 08:26:11 -04:00
Alan Rominger 6f63c7ba38 Merge pull request #2346 from AlanCoding/no_controller_node
No controller node field for project updates
2018-06-29 14:52:34 -04:00
AlanCoding 8ae979908c Enforce unified list field consistency
Discovered via bug: controller_node field present in
project update list but not in detail view

Added tests to assert that "unified" list serializer
produces same fields as the ordinary serializer,
for unified jobs & unified JTs

Added test to check that list serializers do differ
from detail serializer except for allowed differences

Added test to check that list serializers are applied
correctly - only on list views, and that detail views,
likewise, do not use list serializers

Fix the many many bugs discovered by these new
testing mechanisms
2018-06-29 14:03:52 -04:00
Ryan Petrello b2cdf82b78 make settings.SESSIONS_PER_USER work
see: https://github.com/ansible/tower/issues/2209
2018-06-27 12:09:56 -04:00
AlanCoding f753bea24f Test-based fixes to launch config password handling
Fix bug creating WFJT schedule with passwords:
discard survey_passwords field if given in WFJT
prompts processing method.
Fixed by porting prior JT fix to WFJT method of
same name.

Fix bug where API browser will show encrypted form
of variables in the POST submission box after
failed attempt:
copy extra_data so encrypted data values are not
added in still-linked request.data

Fix a bug where submitted extra_data $encrypted$ string
literal was saved because survey_passwords was empty
when there was no diff from prior.

Allow not answering required password questions with a
non-empty default value when saving a launch config.
The literal $encrypted$ string now gets passed into the
prompts / survey validator.
2018-06-20 14:18:38 -04:00
Yunfan Zhang 37d61904bf Merge pull request #2177 from YunfanZhang42/disallow_dict_on_credentials
Disallow posting dictionary as credentials to JT launch API endpoint.
2018-06-20 13:37:21 -04:00
Yunfan Zhang 9fec43c643 Disallow posting dictionary as credentials to JT launch API endpoint. 2018-06-20 13:05:47 -04:00
Alan Rominger d1bc9758db Merge pull request #2060 from AlanCoding/one_less_counter
Get rid of duplicate counter variable
2018-06-20 09:46:03 -04:00
Ryan Petrello ef6433c6f9 Revert "fix celery task reaper"
This reverts commit 1359208a99.
2018-06-18 16:18:20 -04:00
Ryan Petrello eb9083c447 allow the bundled ansible virtualenv to be selected on JT/Proj
see: https://github.com/ansible/awx/issues/34
2018-06-18 14:33:09 -04:00
Christian Adams 7aa835abd4 Merge pull request #2210 from rooftopcellist/fix_refresh_token_fallout
fix oauth2 refresh tests for dat112
2018-06-18 14:31:35 -04:00
adamscmRH b498585c27 fix oauth2 refresh tests for dat112 2018-06-18 13:27:18 -04:00
Chris Meyers ee179c3693 Merge pull request #2174 from chrismeyersfsu/fix-reaper_hostname_map
fix celery task reaper
2018-06-15 17:06:04 -04:00
chris meyers 1359208a99 fix celery task reaper
* celery workers have internal queue names that are named after the
system hostname. This may differ from what tower knows the host by,
Instance.hostname
This adds a mapping so we can convert internal celery names to Instance
names for purposes of reaping jobs.
2018-06-15 16:56:53 -04:00
AlanCoding 16696a6fea get rid of duplicate counter variable 2018-06-15 09:29:13 -04:00
Ryan Petrello 0bcbccba33 enforce True or False for boolean credential injectors
see: https://github.com/ansible/tower/issues/2038
2018-06-14 12:34:54 -04:00
Yunfan Zhang 2a983e3dec Merge pull request #2152 from YunfanZhang42/host_filter_case_insensitive
Make search in Smart Filter case insensitive.
2018-06-13 16:21:00 -04:00
Yunfan Zhang f332c0b8c3 Make search in host_filter case insensitive. 2018-06-13 14:16:48 -04:00
Chris Meyers bc9a934cfe Merge pull request #2110 from chrismeyersfsu/improvement-remove_instance_group_queues2
remove rampart group queue subscription
2018-06-12 11:36:04 -04:00
Alan Rominger ce117285e1 Merge pull request #2079 from AlanCoding/creds_no_op
Allow no-op case when modifying deprecated credentials
2018-06-12 09:08:35 -04:00
Alan Rominger a8c31a51e9 Merge pull request #2004 from AlanCoding/checkin_access
Allow managing credentials with external user management
2018-06-12 07:47:16 -04:00
Alan Rominger 951142d510 Merge pull request #1950 from AlanCoding/more_roles
Cover testing of new 3.3 org roles for user security fix
2018-06-12 07:45:36 -04:00
Jake McDermott 9137b4acef Merge pull request #2114 from jakemcdermott/job-results/host-counts
reduce the minimum number of http requests required to load job details from 7 to 3
2018-06-11 18:19:14 -04:00
Yunfan Zhang 1bc1a6f63f Disallow HTTP update methods in job_detail API endpoint. 2018-06-11 14:47:43 -04:00
Jake McDermott 92ae09e163 add host_status_counts and playbook_counts to project update details 2018-06-08 22:27:41 -04:00
chris meyers fb11967114 remove isolated instance group queue listening 2018-06-08 13:46:58 -04:00
chris meyers 1cea20092c remove rampart group queue subscription
* We now target Instances in the task manager when transitioning jobs
from pending to waiting; whereas before we submitted jobs to Instance
Groups to be picked up by Instance's in those Instance Groups.
Subscribing Instances to their Instance Groups is no longer needed. This
change removes the Instance Group queue subscription.
2018-06-08 11:20:54 -04:00
Yunfan Zhang 1255cfc2f0 Merge pull request #2104 from YunfanZhang42/release_3.3.0
Fix job id incorrectly cast to string in ActiveJobConflict.
2018-06-08 09:53:06 -04:00
Yunfan Zhang 0de369b42f Fix job id incorrectly cast to string in ActiveJobConflict. 2018-06-08 09:31:38 -04:00
Alan Rominger bcd9c5dada Merge pull request #2098 from AlanCoding/u_no_copy
Prohibit users without read_role from viewing copy endpoint
2018-06-08 08:54:32 -04:00
AlanCoding ed762fd4b6 prohibit users without read_role from viewing copy endpoint 2018-06-07 15:14:49 -04:00
AlanCoding b0b7f7a295 prohibit relaunching workflow jobs from other users 2018-06-07 13:01:15 -04:00
Jake McDermott b1f36572c6 Merge pull request #2065 from jakemcdermott/2058
add host_status, play, and task counts to job details
2018-06-07 12:59:11 -04:00
Yunfan Zhang 6f09c1b994 Merge pull request #2090 from YunfanZhang42/fix_test_expect
Fix Jenkins test_expect.
2018-06-07 12:18:19 -04:00
Yunfan Zhang b68ded7c15 Fix tests. 2018-06-07 12:04:20 -04:00