55dc27f243
Set active tab to jobs when initially clicking a workflow_job_template type node
2018-11-27 16:12:42 -05:00
6fc2ba3495
Fixes delete node shifting e2e test
2018-11-27 16:12:42 -05:00
7bad01e193
Fixes e2e workflow visualizer tests
2018-11-27 16:12:42 -05:00
62a1f10c42
Fix node pagination for project/inv
2018-11-27 16:12:42 -05:00
3975a2ecdb
fix linkpath class
2018-11-27 16:12:42 -05:00
bfa361c87f
hide prompt button when not on jobs tab
2018-11-27 16:12:42 -05:00
d5f07a9652
hide inventory help message when not on jobs tab
2018-11-27 16:12:42 -05:00
65ec1d18ad
skip missing inventory prompt value check when selecting workflow node
2018-11-27 16:12:42 -05:00
7b4521f980
workflow node prompt fixup
...
* use workflow model and endpoint when node is workflow
* always include template type in prompt data
* skip missing inventory checks when node is workflow
* skip checks for required credential fields when node is workflow
2018-11-27 16:12:42 -05:00
3762ba7b24
add back in workflow_nodes in order to be able to use it for count of nodes
2018-11-27 16:12:42 -05:00
762c882cd7
consume workflow maker total nodes label change
2018-11-27 16:12:42 -05:00
343639d4b7
fix workflow maker total templates header to total nodes
2018-11-27 16:12:42 -05:00
38dc0b8e90
fix workflow total jobs header to total nodes
2018-11-27 16:12:42 -05:00
ed40ba6267
Fix searching on related fields
2018-11-27 16:12:42 -05:00
54d56f2284
Fix node jobs column sorting. Adds arrows to potential workflow node links
2018-11-27 16:12:42 -05:00
1477bbae30
Fixed error Cannot read property 'type' of undefined in console when selecting a project or inventory node
2018-11-27 16:12:42 -05:00
625c6c30fc
Fixed edge dropdown id
2018-11-27 16:12:42 -05:00
228e412478
simplify workflow job failure reason
...
* Log the more detailed reason for a workflow job failing but expose a
simplified reason to users via job_explanation
2018-11-27 16:12:42 -05:00
f8f2e005ba
better comment for deciding parent's status
2018-11-27 16:12:42 -05:00
d8bf82a8cb
add help_text to do_not_run workflow field
2018-11-27 16:12:41 -05:00
2eeca3cfd7
add example workflow run to docs
2018-11-27 16:12:41 -05:00
28a4bbbe8a
Fixed jshint errors that fell out of merge conflict
2018-11-27 16:12:41 -05:00
1cfcaa72ad
Fixed editNodeHelpMessage logic that was broken during merge conflict
2018-11-27 16:12:41 -05:00
4c14727762
bump migration number
2018-11-27 16:12:41 -05:00
0c8dde9718
fix dfs_run_nodes()
...
* Tried to re-use the topological sort order to crawl the graph to find
the next node(s) to run. This is incorrect, we need to take into account
the fail/success of jobs and directionally crawl the graph.
2018-11-27 16:12:41 -05:00
febf051748
do not mark ujt None nodes dnr
...
* Leave workflow nodes with no related unified job template nodes
do_not_run = False. If we mark it True, we can't differentiate between
the actual want to not take that path vs. do not run this because I do
not have a valid related unified job template.
2018-11-27 16:12:41 -05:00
56885a5da1
Remove reference to isStartNode and just check the id of the node to determine if it's our start node or not
2018-11-27 16:12:41 -05:00
623cf54766
Added dagre and graphlib licenses
2018-11-27 16:12:41 -05:00
a804c854bf
Fix test failures and jshint errors
2018-11-27 16:12:41 -05:00
7b087d4a6c
loop over dnr nodes by topological sort
...
* Perform topological sort on graph nodes before looping over them to
mark do not run. This guarantees that parent nodes will be processed
before calling dependent child nodes. The complexity of the sorting is
N. The complexity of marking the the nodes is N*V
2018-11-27 16:12:41 -05:00
cfa098479e
Revert "optimize mark dnr nodes algorithm"
...
This reverts commit 6372c52772e26f64f3b4fd227ffb5e401d3688e1.
2018-11-27 16:12:41 -05:00
3c510e6344
Fixed bug where root link became clickable. Fix workflow key on results page.
2018-11-27 16:12:41 -05:00
4c9a1d6b90
optimize mark dnr nodes algorithm
...
* Compute largest depth of each node and traverse graph by depth. This
allows us to check a node once, and only once, to determine if it needs
to be marked for do not run.
2018-11-27 16:12:41 -05:00
d1aa52a2a6
fix up mark dnr logic
2018-11-27 16:12:41 -05:00
f30f52a0a8
handle missing unified job template in workflow
...
* Workflow Node without unified_job_template is treated as a job marked
as failure; when deciding what path to execute.
* Remove optimization of marking dnr nodes due to it making the
algorithm incorrect.
2018-11-27 16:12:41 -05:00
5b459e3c5d
Code cleanup. Fixed bugs with workflow results page including details links
2018-11-27 16:12:41 -05:00
676c068b71
add job_description to failed workflow node
...
* When workflow job fails because a workflow job node doesn't have a
related unified_job_template note that with an error on the workflow
job's job_description
* When a workflow job fails because a failure path isn't defined, note
that on the workflow job job_description
2018-11-27 16:12:41 -05:00
00d71cea50
detect workflow nodes without job templates
...
* Fail workflow job run when encountering a Workflow Job Nodes with
no related job templates.
2018-11-27 16:12:41 -05:00
72263c5c7b
Addresses a number of workflow related bugs
2018-11-27 16:12:41 -05:00
281345dd67
flake8 fix
2018-11-27 16:12:41 -05:00
1a85fcd2d5
update docs to include workflow failure semantic
2018-11-27 16:12:41 -05:00
c1171fe4ff
treat canceled nodes as failed when processing wf
...
* When deciding what jobs to run next, treat canceled as failed.
* Also add tests.
2018-11-27 16:12:41 -05:00
d6a8ad0b33
treat canceled jobs in wf the same as failed jobs
...
* Also fix spelling mistake that caused workflows to be falsely marked
successful in the case of a canceled job.
2018-11-27 16:12:41 -05:00
4a6a3b27fa
Fixed a number of workflow visualizer bugs. Added loading spinners while data is being loaded/processed.
2018-11-27 16:12:41 -05:00
266831e26d
add cycle unit test
2018-11-27 16:12:41 -05:00
a6e20eeaaa
update wf done and failed tests
2018-11-27 16:12:41 -05:00
6529c1bb46
update done and fail detection for workflow
...
* Instead of traversing the workflow graph to determine if a workflow is
done or has failed; instead, loop through all the nodes in the graph and
grab only the relevant nodes.
2018-11-27 16:12:41 -05:00
ae0d0db62c
Added dagre to handle our workflow graph layout. Fixed various workflow related bugs.
2018-11-27 16:12:41 -05:00
b81d795c00
fix up dot graph generator
...
* Update graph dot generator to use the new efficient graph
2018-11-27 16:12:41 -05:00
1b87e11d8f
flake8
2018-11-27 16:12:41 -05:00
mabashian
Jake McDermott
John Mitchell
chris meyers
AlanCoding