Matthew Jones
6a1973c873
Disallow deleting job templates when there are jobs running
2016-07-07 12:03:41 -04:00
AlanCoding
25c177cdcd
M2M fix for project activity stream
2016-07-07 10:24:50 -04:00
Matthew Jones
3e0ed4c1a1
Fix up organization default exposed by unit test
2016-07-06 16:36:22 -04:00
Matthew Jones
f75eba471e
Fix flake8 'not in'
2016-07-06 16:09:38 -04:00
Matthew Jones
2528952090
Require organization when creating new notification templates
2016-07-05 15:31:54 -04:00
Wayne Witzel III
c00d32d0eb
Merge pull request #2714 from wwitzel3/issue-2706
...
ensure the singleton roles show up for sys auditor / sys admins
2016-07-01 11:11:58 -04:00
Wayne Witzel III
16bc0cdf0b
add helper decorator to ensure signleton roles see the proper role list
2016-07-01 10:38:02 -04:00
AlanCoding
07bea4c8b0
Revert "Merge pull request #2444 from AlanCoding/2364_access_list_restriction"
...
This reverts commit b71307bf91d1f1a9337071e04ecced012826584b, reversing
changes made to 1be12482954b680ba7a55746594a7e29df9b178d.
2016-07-01 10:10:00 -04:00
Chris Meyers
ecaf2b86b0
flake8 fix
2016-06-30 15:34:48 -04:00
Chris Meyers
84e02a5dd2
fix unit tests and make delete last unattach more generic
2016-06-30 14:13:19 -04:00
Wayne Witzel III
47893613a2
ensure the singleton roles show up for sys auditor / sys admins
2016-06-30 10:55:54 -04:00
Chris Meyers
a57dca9786
fix delete last label disassociate
...
* Inherit from mixin first in order to overwrite next inherited class
method, unattach.
* Also, fix up test and add test to ensure correct inheritance
2016-06-29 17:19:08 -04:00
Alan Rominger
513e6c993f
Merge pull request #2647 from AlanCoding/jt_can_add_betterment
...
A route around get_object_or_400 in JT can_add calcs
2016-06-28 14:31:44 -04:00
Akita Noek
8ad505c9cc
Fixed notification template deleting
...
#2674
2016-06-28 12:27:13 -04:00
Wayne Witzel III
4f534122c5
Merge pull request #2675 from wwitzel3/issue-2244
...
Do not show the read_role child for Teams
2016-06-28 11:43:05 -04:00
Akita Noek
5043ff45c2
Removed active_roles
...
The UI isn't using this feature at the moment so we're going to remove
it for 3.0, and probably bring it back in 3.1, potentially in different
ways depending on UI needs then.
2016-06-28 11:02:28 -04:00
Akita Noek
5ed36624a3
Merge pull request #2664 from anoek/todo-cleanup
...
API todo/fixme addressing and cleanup
2016-06-28 11:01:41 -04:00
Wayne Witzel III
8e89edc27f
Do not show the read_role child for Teams
2016-06-28 10:56:08 -04:00
Akita Noek
9f43b6e60c
Use SubListAPIView for RoleTeamsList
2016-06-28 10:32:36 -04:00
AlanCoding
7b0f20e90d
job template serializer can_add calc to avoid lookups of known related objects
2016-06-28 10:18:30 -04:00
Matthew Jones
4eb6adb5e7
Add notification_template to summary fields
2016-06-27 15:35:34 -04:00
Akita Noek
831c4c2fef
Cleaned up some more stale TODO's and FIXME's (or did / fixed the things)
2016-06-27 15:12:37 -04:00
Akita Noek
4bf50b2d6a
Dead code removal
2016-06-27 15:12:37 -04:00
Akita Noek
bf6767786e
Stale comment cleanup
2016-06-27 15:12:37 -04:00
Akita Noek
b57739a800
Converted except T,e expressions to except T as e
2016-06-27 15:12:37 -04:00
Akita Noek
7839db0c23
Dead code removal
2016-06-27 15:12:37 -04:00
Akita Noek
bf2307946b
Locked down roles teams list
2016-06-27 15:12:37 -04:00
Akita Noek
d3476ed52a
Filter out roles users shouldn't be able to see from parents/children lists
2016-06-27 15:12:37 -04:00
Matthew Jones
78e10241da
Disallow DELETE on a notification_template
...
When there are pending notifications
2016-06-27 11:36:29 -04:00
Wayne Witzel III
f0418d8841
Merge pull request #2634 from wwitzel3/issue-2560
...
Disallow non-admin of a user to add a user to Roles
2016-06-27 11:28:38 -04:00
Wayne Witzel III
ce3ce8d930
enforce read access for team/child roles
2016-06-27 11:02:07 -04:00
Akita Noek
db02b446e5
Merge pull request #2646 from anoek/2628
...
Better handle missing notification_type in patches to notification template
2016-06-27 10:47:04 -04:00
Alan Rominger
9923728797
Merge pull request #2635 from AlanCoding/AS_test_pagination
...
Activity Stream update prefetched fields, avoid a .distinct().count()
2016-06-27 10:29:10 -04:00
Akita Noek
2b323fc24e
Better handle notification template patches for notification_type
...
This makes it so patches don't require the notification_type to be present
2016-06-27 09:40:39 -04:00
Wayne Witzel III
87ffded774
renaming Credential.owner_role -> Credential.admin_role
2016-06-24 16:55:07 -04:00
Akita Noek
9494db583d
Better handle missing notification_type in patches to notification template
...
Addresses #2628
2016-06-24 16:50:27 -04:00
AlanCoding
02dac5299c
Activity Stream prefetch update to new fields, avoid distinct.count repeated queries
2016-06-24 14:19:41 -04:00
Akita Noek
ca2b4766a5
Removed some missed things from our Group role removal work
...
* Removed `groups/n/object_roles`
* Removed `groups/n/access_list`
* `active_roles` from the Group `summary_fields`
#2631
2016-06-24 14:17:20 -04:00
Matthew Jones
a9162278f8
Perform length validation on notification lists
...
Wherever we use a list for notification template configuration we'll now
validate that it contains at least one item at submission time.
2016-06-23 11:31:59 -04:00
Wayne Witzel III
62293341bf
Merge pull request #2592 from wwitzel3/issue-2349
...
filter out duplicate entires for the ActivityStream m2m relations
2016-06-23 11:01:42 -04:00
AlanCoding
d8f11459c9
flake8 fix membership in seralizer
2016-06-23 09:02:44 -04:00
Wayne Witzel III
68d47cfc93
Merge pull request #2574 from wwitzel3/fix-race
...
Ensure teams cannot have org roles as children.
2016-06-22 17:31:27 -04:00
Wayne Witzel III
5277d30d14
filter out duplicate entires for the ActivityStream m2m relations
2016-06-22 17:25:27 -04:00
Matthew Jones
960b6e22aa
Fix up broken CredentialOwnerTeams view
...
Missing the object when requesting whether the user can access it or not
2016-06-22 15:17:45 -04:00
Matthew Jones
87f1f6f8e6
Update inventory script visibility access level
...
admin roles on inv scripts can now see the actual script contents. Read
role doesn't convey that capability.
This should be pretty similar to before from a read_role
perspective... it now allows more folks to see the script contents
2016-06-22 13:48:38 -04:00
Wayne Witzel III
67e516f263
update language in error message
2016-06-22 12:14:11 -04:00
Wayne Witzel III
e07a06e990
Teams cannot be parents of Organization roles
2016-06-22 11:59:40 -04:00
AlanCoding
8fd18b882a
move logic for project udpate to access.py
2016-06-20 12:05:41 -04:00
Chris Church
59361f5151
Fixes suggested by @AlanCoding.
2016-06-17 09:56:27 -04:00
Chris Church
cf7102bc49
Move validation of credential creation to the serializer. Use SubListCreateAPIView for creating a credential under another object, and remove fields from serializer and API docs that aren't valid when creating a credential under another object.
2016-06-17 09:56:27 -04:00
