Commit Graph

19510 Commits

Author SHA1 Message Date
chris meyers 1b87e11d8f flake8 2018-11-27 16:12:41 -05:00
chris meyers 8bb9cfd62a add dag tests 2018-11-27 16:12:41 -05:00
chris meyers a176a4b8cf remove unused code 2018-11-27 16:12:41 -05:00
chris meyers 3f4d14e48d crawl entire graph when marking DNR
* From the root, the code was only going down the did run path to find
nodes to mark DNR. This is incorrect, Now, we traverse the entire graph
each time to find nodes to mark DNR.
2018-11-27 16:12:41 -05:00
chris meyers 0499d419c3 more efficient graph processing
* Getting parent nodes from child was inefficient. Optimize it with a
hash table like we did for the getting of children.
* Getting leaf nodes was inefficient. Optimize it like we did getting
root nodes. A node is assumed to be a leaf node until it gets a child.
2018-11-27 16:12:41 -05:00
mabashian 700860e040 Fix long name tooltip. Fixed bug adding new node before finishing adding new link.
Fixed template list column layout.  Ensure that we're getting 200 workflow nodes per GET request
2018-11-27 16:12:41 -05:00
chris meyers 3dadeb3037 remove print statements 2018-11-27 16:12:41 -05:00
chris meyers 16a60412cf optimization fix
* WorkflowDAG accepts workflow job template and workflow jobs for which
to build a graph out of the nodes. The optimized query for each is
different. This changeset adds the differing queries for a workflow job.
2018-11-27 16:12:41 -05:00
chris meyers 9f3e272665 optimize cycle detection 2018-11-27 16:12:41 -05:00
mabashian b84fc3b111 Fixes for post-rebase bugs 2018-11-27 16:12:41 -05:00
chris meyers e1e8d3b372 bump migration 2018-11-27 16:12:40 -05:00
mabashian 05f4d94db2 Fixed serveral bugs including credential prompting. Added logic to bring links/nodes to the forefront when you hover over them in case there's some overlap 2018-11-27 16:12:40 -05:00
mabashian 61fb3eb390 First pass at implementing better node placement in the workflow graph 2018-11-27 16:12:40 -05:00
mabashian 7b95d2114d Implements workflow convergence without proper layout 2018-11-27 16:12:40 -05:00
chris meyers 07db7a41b3 more flake8 2018-11-27 16:12:40 -05:00
chris meyers 1120f8b1e1 try2 at the devil flake8 2018-11-27 16:12:40 -05:00
chris meyers 17b3996568 fix flake8 anyway I can 2018-11-27 16:12:40 -05:00
chris meyers 584b3f4e3d remove workflow test
* We now handle workflows with jobs that have errored. We treat them the
same as a failure result. Before, we would abort the workflow when we
encountered an error.
2018-11-27 16:12:40 -05:00
chris meyers f8c53f4933 handle job error state in convergence 2018-11-27 16:12:40 -05:00
chris meyers 6e40e9c856 handle edge case ring cycle 2018-11-27 16:12:40 -05:00
chris meyers 2f9dc4d075 remove relationship in view if cycle detected 2018-11-27 16:12:40 -05:00
chris meyers 9afc38b714 fixup migrations 2018-11-27 16:12:40 -05:00
chris meyers dfccc9e07d rework wf cycle detection for convergence 2018-11-27 16:12:40 -05:00
chris meyers 7b22d1b874 cycle detection when multiple parents 2018-11-27 16:12:40 -05:00
mabashian 29b4979736 Completed work necessary to support editing workflow links and nodes separately. Added hover and tooltip to links 2018-11-27 16:12:40 -05:00
mabashian 87d6253176 Decouple editing a wf node with editing a node link 2018-11-27 16:12:40 -05:00
chris meyers 1e10d4323f update docs 2018-11-27 16:12:40 -05:00
chris meyers 4111e53113 correctly name migration to align with 3.4.0 2018-11-27 16:12:40 -05:00
chris meyers 02df0c29e9 merge artifacts deterministically 2018-11-27 16:12:40 -05:00
chris meyers 475c90fd00 prevent job launching twice 2018-11-27 16:12:40 -05:00
chris meyers 2742b00a65 flake8 2018-11-27 16:12:40 -05:00
chris meyers ea29e66a41 fix workflow finish state detector
* Take into account the new do_not_run field when finding if a workflow
is finished. If do_not_run is True then the node is considered finished.
2018-11-27 16:12:40 -05:00
chris meyers 6ef6b649e8 cleaner code 2018-11-27 16:12:40 -05:00
chris meyers 9bf2a49e0f save state 2018-11-27 16:12:40 -05:00
chris meyers 914892c3ac all parents should finish before start child 2018-11-27 16:12:40 -05:00
chris meyers 77661c6032 short circuit performance optimization 2018-11-27 16:12:40 -05:00
chris meyers b4fc585495 stop DNR propogation on always path
* This makes sure DNR propogation stops when a job is successful, down
an always path
2018-11-27 16:12:40 -05:00
chris meyers ff6db37a95 correct stop DNR propogation
* If a child has a parent that is not in the finished state then do not
propogate the DNR to the child in question.
* If a parent is in a finished state; do not propogate the DNR to the
child if the path to the child is traversed (based on the parent job
status).
2018-11-27 16:12:40 -05:00
chris meyers 1a064bdc59 satisfy flake8 2018-11-27 16:12:40 -05:00
chris meyers ebabec0dad always find and mark dnr nodes 2018-11-27 16:12:40 -05:00
chris meyers 3506b9a7d8 Revert "mark dnr field read only"
This reverts commit 3dbc52d91223167683fd01174222bd6c22813dbd.

Workflow Job Nodes are read only already
2018-11-27 16:12:40 -05:00
chris meyers cc374ca705 update debug dot graph to output dnr data 2018-11-27 16:12:40 -05:00
chris meyers ad56a27cc0 mark dnr field read only 2018-11-27 16:12:40 -05:00
chris meyers 779e1a34db remove dnr field from jt wf node 2018-11-27 16:12:40 -05:00
chris meyers 447dfbb64d only visit nodes once for dnr 2018-11-27 16:12:40 -05:00
chris meyers a9365a3967 code cleanup 2018-11-27 16:12:40 -05:00
chris meyers f5c10f99b0 support workflow convergence nodes
* remove convergence restriction in API
* change task manager logic to be aware of and support convergence nodes
2018-11-27 16:12:40 -05:00
softwarefactory-project-zuul[bot] c53ccc8d4a Merge pull request #2813 from shanemcd/update-translation-templates
Extract latest strings from source code for translations

Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2018-11-27 17:53:49 +00:00
softwarefactory-project-zuul[bot] de77f6bd1f Merge pull request #2809 from jlmitch5/fixManagmentJobScheduleEditLink
fix management job schedule edit link button

Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2018-11-27 17:33:07 +00:00
Shane McDonald 18c4771a38 Extract latest strings from source code for translations 2018-11-27 12:31:52 -05:00