a4873d97d8
Raise a validation error if a credential is set while the service is not
2019-09-30 13:32:22 -04:00
efe4ea6575
Fix the webhook receiver url for workflow jobs
2019-09-30 13:32:22 -04:00
b415c31b4f
Fix problems with posting to Gitlab's API
2019-09-30 13:32:22 -04:00
e91462d085
Update the Webhook Credential help text tooltip
...
to make it more apparent to the user that this is an optional part of
the feature, and that failure to add a webhook credential will disable
status post-backs.
2019-09-30 13:32:22 -04:00
e85ff83be6
Apply 403 alert fixes for Workflows, too
2019-09-30 13:32:22 -04:00
d500c1bb40
Don't alert user of 403 errors for webhook key
2019-09-30 13:32:22 -04:00
885841caea
Drop Bitbucket support
...
since only the Bitbucket Server product supports signed payloads,
bitbucket.org does not. And we are requiring signed payloads.
2019-09-30 13:32:22 -04:00
f7396cf81a
Always include selected webhook service in creation requests
2019-09-30 13:32:22 -04:00
286da3a7eb
Posting webhook status now works
2019-09-30 13:32:21 -04:00
40b03eb6ef
Enable the call to update_webhook_status
...
by calling it directly within send_notification_templates. Also,
update the context field in the payload to be either 'ansible/awx' or
'ansible/tower', depending on which is being used.
2019-09-30 13:32:21 -04:00
c76c531b7a
Provide a payload for the webhook status post-back
2019-09-30 13:32:21 -04:00
75d3359b6f
make label consistent with help text
2019-09-30 13:32:21 -04:00
4ad5054222
Add logic to post the job status for webhooks back to the service
...
under some circumstances.
2019-09-30 13:32:21 -04:00
aa34984d7c
Fix the git ref extractor for Gitlab pull requests
2019-09-30 13:32:21 -04:00
08594682a4
stub options request in workflow add unit test
2019-09-30 13:32:21 -04:00
d73abda5d1
Update the webhook receiver git ref extractor logic
...
to deal with the null-ref case, and to deal correctly with Github push events.
2019-09-30 13:32:21 -04:00
3bc91f123e
add trailing '/' to webhook urls
2019-09-30 13:32:21 -04:00
41ba5c0968
add webhook fields to workflow unit test mock
2019-09-30 13:32:21 -04:00
e8e3a601b2
Pull out a git ref for each event type where we might care
2019-09-30 13:32:21 -04:00
b96c03e456
represent webhooks on job lists
2019-09-30 13:32:21 -04:00
5e9448a854
always show launched by webhook details if there's a webhook guid
2019-09-30 13:32:21 -04:00
6b17e86f30
add launched-by-webhook details to job runs
2019-09-30 13:32:21 -04:00
00337990db
add webhook fields to workflows
2019-09-30 13:32:21 -04:00
1a33ae61a7
use key icon for webhook cred
2019-09-30 13:32:21 -04:00
5f7bfaa20a
support server-side webhook key generation
2019-09-30 13:32:21 -04:00
178a2c7c49
Disable the authentication classes for the webhook receivers
...
One of them was consuming the body of the posts. We do still need to
have an extraneous `request.body` expression, though now in
WebhookReceiverBase.post, since the `request.data` expression in the
logging also consumes the request body.
2019-09-30 13:32:20 -04:00
58e5f02129
Expose the new webhook fields in the job and workflow serializers
2019-09-30 13:32:20 -04:00
dd6c97ed87
Include a message in the webhook response
2019-09-30 13:32:20 -04:00
7aa424b210
Make sure that the new webhook fields are populated when firing off a job
...
Also, added a temporary hacky workaround for the fact that something
in our request/response stack for APIView is consuming the request
contents in an unfriendly way, preventing the `.body` @property from
working.
2019-09-30 13:32:20 -04:00
e0a363beb8
issue network calls for setting and getting webhook key
2019-09-30 13:32:20 -04:00
48eb502161
wip
2019-09-30 13:32:20 -04:00
151de89c26
add webhook credential field
2019-09-30 13:32:20 -04:00
f5c151d5c4
add webhook url field
2019-09-30 13:32:20 -04:00
17b34b1e36
add webhook service field
2019-09-30 13:32:20 -04:00
ee1d118752
Add the webhook receiver url to the related urls in the serializers
2019-09-30 13:32:20 -04:00
245931f603
Debounce when multiple copies of the same webhook event come in
2019-09-30 13:26:04 -04:00
095aa77857
Create a new model mixin for Job and WorkflowJob webhook fields
2019-09-30 13:26:04 -04:00
bb1397a3d4
Validate the webhook credential
...
- we should allow a null credential, so that the admin can choose to configure not posting back status changes of the triggered job
- the credential must be of the new 'token' kind
- if we do configure a credential, its type must match the selected SCM service
2019-09-30 13:26:04 -04:00
5848f0360a
Update test_default_cred_types to include the new personal access token types
2019-09-30 13:26:04 -04:00
83fc2187cc
Fix the summary fields for webhook_credential
2019-09-30 13:26:04 -04:00
4dba9916dc
Add a new set of personal access token credential types
2019-09-30 13:26:03 -04:00
8836ed44ce
Construct an ID for Gitlab webhooks
...
by taking the SHA1 of the body of the webhook request.
2019-09-30 13:26:03 -04:00
992c414737
Launch a Job or WorkflowJob based on the incoming webhook
2019-09-30 13:26:03 -04:00
66a8186995
Get the webhook receiver views to work at least minimally
2019-09-30 13:26:03 -04:00
fa15696ffe
Remove some dead comments
2019-09-30 13:26:03 -04:00
82a0dc0024
Cycle or unset the webhook key if the webhook service changes
...
Also, tests.
2019-09-30 13:26:03 -04:00
d4b20b7340
Update tests to use the expect keyword argument for get() and post()
2019-09-30 13:26:03 -04:00
c0ad5a7768
Expose the webhook_service and webhook_credential fields in the serializer
...
webhook_credential specifically as a summary field.
2019-09-30 13:26:03 -04:00
d9ac291115
Add some RBAC oriented tests for the webhook secret key view
2019-09-30 13:26:03 -04:00
6b86cf6e86
Revert to using the explicit dispatch to the appropriate model
...
since passing the model class at url include time doesn't work.
2019-09-30 13:26:03 -04:00
Jeff Bradberry
Jake McDermott